-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a common settings class to initialize plugin settings #361
Added a common settings class to initialize plugin settings #361
Conversation
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
============================================
+ Coverage 72.52% 72.55% +0.03%
- Complexity 570 572 +2
============================================
Files 73 72 -1
Lines 2984 2988 +4
Branches 226 226
============================================
+ Hits 2164 2168 +4
Misses 716 716
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, thanks @owaiskazi19
* Moved settings to a common singleton class Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Removed update retry settings Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Used getter for maxRetry value Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Removed FeatureEnabledSettings file Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Fixed tests Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Moved max workflow step setting to common class Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> (cherry picked from commit a8e7ff5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…tings (#370) Added a common settings class to initialize plugin settings (#361) * Moved settings to a common singleton class * Removed update retry settings * Used getter for maxRetry value * Removed FeatureEnabledSettings file * Fixed tests * Moved max workflow step setting to common class --------- (cherry picked from commit a8e7ff5) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR achieves the below:
Note: Settings used in Rest classes works well as initialized by the REST call.
Testing:
Issues Resolved
Fixes #351
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.