Consume REST params and consistently handle error messages #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
This was
linked to
issues
Dec 15, 2023
joshpalis
approved these changes
Dec 15, 2023
amitgalitz
approved these changes
Dec 15, 2023
dbwiddis
merged commit 1065208
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…h-project#295) * Always consume the workflow_id param Signed-off-by: Daniel Widdis <widdis@gmail.com> * Delegate no-content error message to BaseRestHandler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't lose FlowFrameworkException status Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…h-project#295) * Always consume the workflow_id param Signed-off-by: Daniel Widdis <widdis@gmail.com> * Delegate no-content error message to BaseRestHandler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't lose FlowFrameworkException status Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…h-project#295) * Always consume the workflow_id param Signed-off-by: Daniel Widdis <widdis@gmail.com> * Delegate no-content error message to BaseRestHandler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't lose FlowFrameworkException status Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…h-project#295) * Always consume the workflow_id param Signed-off-by: Daniel Widdis <widdis@gmail.com> * Delegate no-content error message to BaseRestHandler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't lose FlowFrameworkException status Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
* Always consume the workflow_id param Signed-off-by: Daniel Widdis <widdis@gmail.com> * Delegate no-content error message to BaseRestHandler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't lose FlowFrameworkException status Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…h-project#295) * Always consume the workflow_id param Signed-off-by: Daniel Widdis <widdis@gmail.com> * Delegate no-content error message to BaseRestHandler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't lose FlowFrameworkException status Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
added a commit
that referenced
this pull request
Dec 18, 2023
* Always consume the workflow_id param Signed-off-by: Daniel Widdis <widdis@gmail.com> * Delegate no-content error message to BaseRestHandler Signed-off-by: Daniel Widdis <widdis@gmail.com> * Don't lose FlowFrameworkException status Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
workflow_idparam before any other error handling, so it doesn't get swallowed by BaseRestHandler consumed-param checksIssues Resolved
Fixes #274
Fixes #292
Fixes #293
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.