Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit ordering of tools in register agent step #283

Merged

Conversation

dbwiddis
Copy link
Member

Description

Allows users to include an optional "tools" field in the register agent node. If present, any previous nodes listed in that array will be used in order prior to any other tools listed in previous inputs. Duplicates will be ignored ("tools" field takes priority).

Issues Resolved

Fixes #281

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbwiddis dbwiddis merged commit 834cb7a into opensearch-project:feature/agent_framework Dec 13, 2023
10 checks passed
@dbwiddis dbwiddis deleted the ordered-tools branch December 13, 2023 22:18
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 15, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis added a commit that referenced this pull request Dec 18, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis added a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis added a commit that referenced this pull request Dec 18, 2023
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants