-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/agent_framework] Add Get Workflow API to retrieve a stored template by workflow id #273
Merged
joshpalis
merged 6 commits into
opensearch-project:feature/agent_framework
from
joshpalis:get
Dec 13, 2023
Merged
[Feature/agent_framework] Add Get Workflow API to retrieve a stored template by workflow id #273
joshpalis
merged 6 commits into
opensearch-project:feature/agent_framework
from
joshpalis:get
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
December 11, 2023 22:30
amitgalitz
reviewed
Dec 11, 2023
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStateAction.java
Show resolved
Hide resolved
amitgalitz
reviewed
Dec 11, 2023
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStateRequest.java
Show resolved
Hide resolved
dbwiddis
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick look but then I got lost in the file renames and changes. I agree "Get" is poorly named for the status API but I'm not sure what all the new APIs do. Can you summarize quickly in the PR summary/first-comment?
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowAction.java
Show resolved
Hide resolved
amitgalitz
reviewed
Dec 12, 2023
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowAction.java
Outdated
Show resolved
Hide resolved
amitgalitz
reviewed
Dec 12, 2023
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowStateAction.java
Show resolved
Hide resolved
Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
approved these changes
Dec 13, 2023
amitgalitz
approved these changes
Dec 13, 2023
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
merged commit Dec 13, 2023
a00a715
into
opensearch-project:feature/agent_framework
10 checks passed
This was referenced Dec 13, 2023
28 tasks
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
template by workflow id (opensearch-project#273) * renaming status API implementation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding GetWorkflow API Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding todo reminder Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
template by workflow id (opensearch-project#273) * renaming status API implementation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding GetWorkflow API Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding todo reminder Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
template by workflow id (opensearch-project#273) * renaming status API implementation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding GetWorkflow API Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding todo reminder Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
template by workflow id (opensearch-project#273) * renaming status API implementation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding GetWorkflow API Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding todo reminder Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
template by workflow id (#273) * renaming status API implementation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding GetWorkflow API Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding todo reminder Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
template by workflow id (opensearch-project#273) * renaming status API implementation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding GetWorkflow API Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding todo reminder Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
template by workflow id (#273) * renaming status API implementation Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding GetWorkflow API Signed-off-by: Joshua Palis <jpalis@amazon.com> * addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding todo reminder Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #263 in favor of this PR
Adds a Get Workflow API that retrieves a workflow from the Global Context index. We've decided to instead just rename the Get Workflow State API implementation and keep this and the Get Workflow API separate (separate handlers, separate request response classes, separate transport action handlers). I have updated the
RestGetWorkflowAction
->RestGetWorkflowStateAction
,GetWorkflowTransportAction
->GetWorkflowStateTransportAction
,GetWorkflowRequest
->GetWorkflowStateRequest
, etc.The name
RestGetWorkflowAction
,GetWorkflowTransportAction
will be used for this PR's APICreating a workflow :
Using the API :
Issues Resolved
#170
Part of #88
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.