Includ workflow id and current node id in the exception message #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g registe agent step Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
amitgalitz
as code owners
joshpalis
approved these changes
Dec 7, 2023
dbwiddis
approved these changes
Dec 8, 2023
dbwiddis
merged commit 2c1401c
into
opensearch-project:feature/agent_framework
10 checks passed
28 tasks
|
@jackiehanyang #244 is a common issue for all the workflow steps. Currently, we don't log workflow id or node id for any workflow steps for success or failure cases and not just specific to register agent step. |
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…search-project#262) Includ workflow id and current node id in the exception message during registe agent step Signed-off-by: Jackie Han <jkhanjob@gmail.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 15, 2023
…search-project#262) Includ workflow id and current node id in the exception message during registe agent step Signed-off-by: Jackie Han <jkhanjob@gmail.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
Includ workflow id and current node id in the exception message during registe agent step Signed-off-by: Jackie Han <jkhanjob@gmail.com>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
…search-project#262) Includ workflow id and current node id in the exception message during registe agent step Signed-off-by: Jackie Han <jkhanjob@gmail.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 18, 2023
Includ workflow id and current node id in the exception message during registe agent step Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently some error message during register agent step is not clear enough for customer to debug further. Therefore, this pr adds workflow id and current node id into the exception message.
Issues Resolved
#244
#242 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.