-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test infrastructure set up #230
Conversation
…luster and fixes ./gradlew run Signed-off-by: Joshua Palis <jpalis@amazon.com>
Thanks for adding this! Could you change our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just one minor comment to update the developer guide
Signed-off-by: Joshua Palis <jpalis@amazon.com>
@owaiskazi19 I'm opting not to backport this to the |
+1, there is no clean way to pull and build custom zips based on branches without extra boilerplate and workarounds that would need to be inevitably reverted. |
* Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run Signed-off-by: Joshua Palis <jpalis@amazon.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating DEVELOPER_GUIDE Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit aba7dea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Integration test infrastructure set up (#230) * Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run * spotless * Updating DEVELOPER_GUIDE --------- (cherry picked from commit aba7dea) Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run Signed-off-by: Joshua Palis <jpalis@amazon.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating DEVELOPER_GUIDE Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com>
* Rename repo name in code files and CI (#182) Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Update actions/setup-java action to v4 (#219) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Use only pluginZip publication of Apache Maven artifacts (#226) * Use only pluginZip publication of Apache Maven artifacts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Integration test infrastructure set up (#230) * Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run Signed-off-by: Joshua Palis <jpalis@amazon.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating DEVELOPER_GUIDE Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.2 (#229) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update to Gradle 8.5 (#227) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.3 (#252) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update dependency org.eclipse.platform:org.eclipse.core.runtime to v3.30.0 (#255) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Add setting to limit max workflow steps Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Joshua Palis <jpalis@amazon.com>
* Rename repo name in code files and CI (#182) Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> * Update actions/setup-java action to v4 (#219) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Use only pluginZip publication of Apache Maven artifacts (#226) * Use only pluginZip publication of Apache Maven artifacts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Integration test infrastructure set up (#230) * Initial integ test framework modification, sets up integration test cluster and fixes ./gradlew run Signed-off-by: Joshua Palis <jpalis@amazon.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating DEVELOPER_GUIDE Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.2 (#229) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update to Gradle 8.5 (#227) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v6.23.3 (#252) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Update dependency org.eclipse.platform:org.eclipse.core.runtime to v3.30.0 (#255) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> * Add setting to limit max workflow steps Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit 7bec6e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR sets up the initial integration test cluster infrastructure. We iterate through all the
zipArchive
dependencies and install them into the cluster prior to installing the flow framework plugin. As we add support for additional plugin APIs, to add them to the test cluster, all we need to do is to add the relatedzipArchive
under dependencies.Additionally this PR fixes our
./gradlew run
task which uses the integration test cluster. Now when you./gradlew run
both ML-commons and Flow Framework will be automatically installed into a local clusterIssues Resolved
Part of #88
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.