Added Create Connector Step #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
create-connector
branch
from
e2b640e
to
3f7dfb6
Compare
owaiskazi19
changed the title
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
============================================
+ Coverage 80.47% 80.55% +0.08%
- Complexity 252 262 +10
============================================
Files 30 30
Lines 973 1039 +66
Branches 98 103 +5
============================================
+ Hits 783 837 +54
- Misses 155 164 +9
- Partials 35 38 +3
|
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
reviewed
Oct 20, 2023
src/main/java/org/opensearch/flowframework/workflow/CreateConnectorStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateConnectorStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateConnectorStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/DeployModelStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/RegisterModelStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/CreateConnectorStep.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
joshpalis
reviewed
Oct 20, 2023
src/main/java/org/opensearch/flowframework/workflow/CreateConnectorStep.java
Show resolved
Hide resolved
joshpalis
reviewed
Oct 20, 2023
src/main/java/org/opensearch/flowframework/workflow/RegisterModelStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/DeployModelStep.java
Outdated
Show resolved
Hide resolved
dbwiddis
reviewed
Oct 25, 2023
amitgalitz
approved these changes
Oct 25, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Added initial implementation of create connector Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Added test for create connector Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Added more tests and updated MLClient initialization Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Addressed PR comments Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * CompletedFuture exceptionally if fields are not present Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> --------- Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit 23b2f15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Oct 25, 2023
Added Create Connector Step (#107) * Added initial implementation of create connector * Added test for create connector * Added more tests and updated MLClient initialization * Addressed PR comments * CompletedFuture exceptionally if fields are not present --------- (cherry picked from commit 23b2f15) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Fixes #70
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.