Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index.query.max_nested_depth fix #6346 #6347

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Add index.query.max_nested_depth fix #6346 #6347

merged 5 commits into from
Mar 19, 2024

Conversation

mkhludnev
Copy link
Contributor

@mkhludnev mkhludnev commented Feb 3, 2024 •
edited
Loading

Description

Document index.query.max_nested_depth setting.

Issues Resolved

Closes #6346

this documents 2.x change opensearch-project/OpenSearch#11670

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mkhludnev
Document index.query.max_nested_depth fix opensearch-project#6346
fc800b8 
Signed-off-by: Mikhail Khludnev <mkhludnev@users.noreply.github.com>
@mkhludnev mkhludnev mentioned this pull request Feb 3, 2024
Closed
kolchfa-aws
kolchfa-aws approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mkhludnev! A small change and this PR will be ready to merge. Is this for 2.12?

_install-and-configure/configuring-opensearch/index-settings.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws self-assigned this Feb 5, 2024
@mkhludnev @kolchfa-aws
fix index.query.max_nested_depth
48d0f8a 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Mikhail Khludnev <mkhludnev@users.noreply.github.com>
@mkhludnev
Copy link
Contributor Author

mkhludnev commented Feb 5, 2024 •
edited
Loading

Thank you, @mkhludnev! A small change and this PR will be ready to merge.

Appreciate!

Is this for 2.12?

depends on opensearch-project/OpenSearch#11670

natebower
natebower approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "20" and "1" be in code font? Otherwise, LGTM.

@mkhludnev
Copy link
Contributor Author

Should "20" and "1" be in code font? Otherwise, LGTM.

Fully agree. But neither is numbers around follow this convention.

@hdhalter hdhalter added 6 - Done but waiting to merge PR: The work is done and ready to merge v2.12.0 release-notes PR: Include this PR in the automated release notes and removed release-notes PR: Include this PR in the automated release notes v2.12.0 labels Feb 7, 2024
@reta
Copy link
Contributor

reta commented Feb 10, 2024

@kolchfa-aws this is going to land in 2.13.0

@mkhludnev
Copy link
Contributor Author

Still little bit puzzled.

mkhludnev and others added 3 commits February 13, 2024 21:57
@mkhludnev @reta
Update _install-and-configure/configuring-opensearch/index-settings.md
e955444 
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Mikhail Khludnev <mkhludnev@users.noreply.github.com>
@mkhludnev
Update index-settings.md
e520efc 
Signed-off-by: Mikhail Khludnev <mkhludnev@users.noreply.github.com>
@mkhludnev
Update index-settings.md
3292e7e 
Signed-off-by: Mikhail Khludnev <mkhludnev@users.noreply.github.com>
@mkhludnev
Copy link
Contributor Author

Done with applying suggestion for 2.13. Still not clear how we remember to change documentation for default for 3.x corresponding to opensearch-project/OpenSearch#11670?

@hdhalter
Copy link
Contributor

Done with applying suggestion for 2.13. Still not clear how we remember to change documentation for default for 3.x corresponding to opensearch-project/OpenSearch#11670?

Thanks, @mkhludnev ! You can create a new documentation issue that describes the changes for 3.0 and points to the change in functionality, or go straight to a PR. We will label it as '3.0'.

@mkhludnev
Copy link
Contributor Author

Great @hdhalter. After this is merged I spin 3.0 PR.

@hdhalter hdhalter added release-notes PR: Include this PR in the automated release notes 4 - Doc review PR: Doc review in progress and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Mar 13, 2024
@kolchfa-aws
Copy link
Collaborator

@mkhludnev Is this PR ready to merge for 2.13?

@mkhludnev
Copy link
Contributor Author

@mkhludnev Is this PR ready to merge for 2.13?

I think so opensearch-project/OpenSearch#12286 (comment)

@hdhalter hdhalter added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 4 - Doc review PR: Doc review in progress labels Mar 18, 2024
@mkhludnev mkhludnev mentioned this pull request Mar 18, 2024
Closed
4 tasks
@hdhalter hdhalter changed the title Document index.query.max_nested_depth fix #6346 Add index.query.max_nested_depth fix #6346 Mar 18, 2024
@kolchfa-aws kolchfa-aws merged commit 9280438 into opensearch-project:main Mar 19, 2024
4 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@natebower natebower natebower approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli vagimeli is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] describe index.query.max_nested_depth setting
5 participants
@mkhludnev @reta @hdhalter @kolchfa-aws @natebower