Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC} Reconcile Alerting Monitors 2.9 Documentation Changes #4710

Merged
merged 35 commits into from
Aug 21, 2023
Merged

[DOC} Reconcile Alerting Monitors 2.9 Documentation Changes #4710

merged 35 commits into from
Aug 21, 2023

Conversation

vagimeli
Copy link
Collaborator

@vagimeli vagimeli commented Aug 7, 2023 •
edited
Loading

… simultaneously

Description

PRs #4525 and #4127 were worked on by two tech writers. Merged changes in 4525 were overridden but not incorporated by #4127. This PR is resolving that issue. This PR also resolves the Alerting Monitors info architecture as follows:

  • Alerting (grand_parent)
  • Monitors (parent)
  • per document monitors (child)
  • per cluster metrics monitors (child)
  • per bucket monitors (child)
  • per query monitors (child)
  • composite monitors (child)
  • triggers (child)
  • actions (child)

Issues Resolved

#4708

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli
Reconcile PR changes that weren't published due to files being edited…
d746d7f 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added backport 2.9 PR: Backport label for 2.9 2 - In progress Issue/PR: The issue or PR is in progress. labels Aug 7, 2023
@vagimeli vagimeli linked an issue Aug 7, 2023 that may be closed by this pull request
[DOC] Resolve content and structure conflict issues #4708
Closed
4 tasks
@vagimeli
Copy link
Collaborator Author

vagimeli commented Aug 7, 2023 •
edited
Loading

@cwillum Please review the monitors.md file. We need to make sure the changes in #4127 are in this monitors.md file.

FYI--Destinations changed to Notifications. Deleted that section. Users go to Notifications documentation instead.

Here's the new structure

Screenshot 2023-08-07 at 5 33 27 PM Screenshot 2023-08-07 at 5 30 50 PM

@vagimeli
Reconcile PR changes that weren't published due to files being edited…
08377c3 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
94ae28f 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
77d6df4 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
14614f9 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Collaborator Author

vagimeli commented Aug 7, 2023 •
edited
Loading

For visibility @mnkugler @brijos @hdhalter

@vagimeli
Reconcile PR changes that weren't published due to files being edited…
6454948 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
2da06ef 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
b67143a 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
fa2de7d 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
d837d56 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
9cf5327 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Reconcile PR changes that weren't published due to files being edited…
57a63af 
… simultaneously

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
cwillum
cwillum reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli I looked over the monitors.md file and changed some links. Thanks.

_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
vagimeli and others added 2 commits August 16, 2023 11:05
@vagimeli @cwillum
Update _observing-your-data/alerting/monitors.md
589727b 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/monitors.md
02046b7 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Address doc reviewer feedback
51cef56 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Make copy edits
a87bedb 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Make copy edits
3f7a749 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Make copy edits
4b3bed8 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Make copy edits
f5f42cb 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Make copy edits
013d0f4 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli requested a review from cwillum August 18, 2023 14:37
@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Aug 18, 2023
cwillum
cwillum approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Suggestions included.

_observing-your-data/alerting/monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-cluster-metrics-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-cluster-metrics-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-cluster-metrics-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-cluster-metrics-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-cluster-metrics-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-document-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-query-bucket-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-query-bucket-monitors.md Outdated Show resolved Hide resolved
_observing-your-data/alerting/per-query-bucket-monitors.md Outdated Show resolved Hide resolved
vagimeli and others added 12 commits August 21, 2023 12:17
@vagimeli @cwillum
Update _observing-your-data/alerting/per-cluster-metrics-monitors.md
32ff232 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/monitors.md
2007e0d 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-cluster-metrics-monitors.md
fd6eb1c 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-cluster-metrics-monitors.md
b7e53c0 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-cluster-metrics-monitors.md
29cc3fd 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-cluster-metrics-monitors.md
a37a368 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-cluster-metrics-monitors.md
30cb8d8 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-document-monitors.md
f9cab4d 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-query-bucket-monitors.md
e162c27 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-query-bucket-monitors.md
4fa621d 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-query-bucket-monitors.md
dc92009 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @cwillum
Update _observing-your-data/alerting/per-cluster-metrics-monitors.md
824a820 
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Collaborator Author

Looks good. Suggestions included.

@cwillum Thanks for the review. I accepted your changes.

@vagimeli vagimeli merged commit fc14355 into main Aug 21, 2023
4 checks passed
@vagimeli vagimeli deleted the fix-structure-4708 branch August 21, 2023 18:22
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 21, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 21, 2023
@github-actions @cwillum
[DOC} Reconcile Alerting Monitors 2.9 Documentation Changes (#4710)
a505994 
* Reconcile PR changes that weren't published due to files being edited simultaneously

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
(cherry picked from commit fc14355)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Aug 22, 2023
@opensearch-trigger-bot @github-actions @cwillum
[DOC} Reconcile Alerting Monitors 2.9 Documentation Changes (#4710) (#…
bfd424b 
…4846)

* Reconcile PR changes that weren't published due to files being edited simultaneously

---------



(cherry picked from commit fc14355)

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
@vagimeli @cwillum @harshavamsi
[DOC} Reconcile Alerting Monitors 2.9 Documentation Changes (opensear…
6751a3c 
…ch-project#4710)

* Reconcile PR changes that weren't published due to files being edited simultaneously

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
vagimeli added a commit that referenced this pull request Dec 21, 2023
@vagimeli @cwillum
[DOC} Reconcile Alerting Monitors 2.9 Documentation Changes (#4710)
028dad0 
* Reconcile PR changes that weren't published due to files being edited simultaneously

---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Chris Moore <107723039+cwillum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwillum cwillum cwillum approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@ananzh ananzh Awaiting requested review from ananzh

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

Assignees

@vagimeli vagimeli

@cwillum cwillum

Labels
4 - Doc review PR: Doc review in progress backport 2.9 PR: Backport label for 2.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Resolve content and structure conflict issues
2 participants
@vagimeli @cwillum