Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Sort Index Dropdown and Implement ComboBox #358

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nung22
Copy link
Contributor

@nung22 nung22 commented Dec 19, 2023

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.95%. Comparing base (3bfbfda) to head (2f06713).

❗ Current head 2f06713 differs from pull request most recent head 813dd61. Consider uploading reports for the commit 813dd61 to get more accurate results

Files Patch % Lines
...search_components/search_configs/search_config.tsx 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   83.13%   82.95%   -0.19%     
==========================================
  Files          32       32              
  Lines         415      393      -22     
  Branches       81       79       -2     
==========================================
- Hits          345      326      -19     
+ Misses         49       47       -2     
+ Partials       21       20       -1     
Flag Coverage Δ
dashboards-search-relevance 82.95% <50.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli
Copy link
Member

sejli commented Dec 27, 2023

Saw this on #342. Could we try implementing the DataSourceSelectable component instead?

cc: @ashwin-pc in case more context is needed

@nung22 nung22 changed the title [FEATURE] Sort Index Dropdown and Implement ComboBox Feature: Sort Index Dropdown and Implement ComboBox Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants