Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove babel-proposal plugins #355

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Remove babel-proposal plugins #355

merged 5 commits into from
Dec 12, 2023

Conversation

sejli
Copy link
Member

@sejli sejli commented Dec 6, 2023

Description

The OSD team updated the proposal plugins to their transform equivalents in this PR, which broke our builds. Removing proposal plugins, as they are not needed.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sean Li <lnse@amazon.com>
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e7923a) 83.46% compared to head (29ae306) 83.54%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   83.46%   83.54%   +0.08%     
==========================================
  Files          32       32              
  Lines         393      395       +2     
  Branches       77       77              
==========================================
+ Hits          328      330       +2     
  Misses         45       45              
  Partials       20       20              
Flag Coverage Δ
dashboards-search-relevance 83.54% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noCharger
Copy link
Collaborator

@sejli Integ test failed, can you look into? Thanks.

error chromedriver@119.0.1: The engine "node" is incompatible with this module. Expected version ">=18". Got "14.20.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: /opt/hostedtoolcache/node/14.20.1/x64/lib/node_modules/yarn/bin/yarn.js install --non-interactive
          at makeError (/home/runner/work/dashboards-search-relevance/dashboards-search-relevance/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:26834:11)
          at handlePromise (/home/runner/work/dashboards-search-relevance/dashboards-search-relevance/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:25770:26)
          at processTicksAndRejections (internal/process/task_queues.js:[95](https://github.com/opensearch-project/dashboards-search-relevance/actions/runs/7108606750/job/19352472436?pr=355#step:13:96):5)
          at async installInDir (/home/runner/work/dashboards-search-relevance/dashboards-search-relevance/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:25493:3)
          at async Project.installDependencies (/home/runner/work/dashboards-search-relevance/dashboards-search-relevance/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:15231:5)
          at async Object.run (/home/runner/work/dashboards-search-relevance/dashboards-search-relevance/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:9188:11)
          at async runCommand (/home/runner/work/dashboards-search-relevance/dashboards-search-relevance/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:58240:5)
          at async Object.run (/home/runner/work/dashboards-search-relevance/dashboards-search-relevance/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:278:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli sejli merged commit c2f175b into opensearch-project:main Dec 12, 2023
12 checks passed
github-actions bot added a commit that referenced this pull request Dec 12, 2023
* removing babel proposal

Signed-off-by: Sean Li <lnse@amazon.com>

* updating remote integ test workflow

Signed-off-by: Sean Li <lnse@amazon.com>

* sleep until OSD starts based on api/status

Signed-off-by: Sean Li <lnse@amazon.com>

* increasing sleep time

Signed-off-by: Sean Li <lnse@amazon.com>

* extending request timeout

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit c2f175b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli pushed a commit that referenced this pull request Dec 12, 2023
* removing babel proposal



* updating remote integ test workflow



* sleep until OSD starts based on api/status



* increasing sleep time



* extending request timeout



---------


(cherry picked from commit c2f175b)

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants