fix(log explorer): show PPL errors in toasts correctly #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
data source id is always undefined because log explorer doesn't support multi-datasource. passing undefined fixes the parameters so UI shows PPL errors in toasts Signed-off-by: Joshua Li <joshuali925@gmail.com>
using `prepend` property the icon will be smaller than its original size, but since the text field is now `compact` and original size doesn't fit anymore, we can revert back to use `prepend`. Signed-off-by: Joshua Li <joshuali925@gmail.com>
Swiddis
approved these changes
Sep 10, 2024
| @@ -52,7 +52,7 @@ export const useFetchEvents = ({ pplService, requestParams }: IFetchEventsParams | |||
| ) => { | |||
| setIsEventsLoading(true); | |||
| return pplService | |||
| .fetch({ query, format }, errorHandler) | |||
| .fetch({ query, format }, undefined, errorHandler) | |||
There was a problem hiding this comment.
it's regression from MDS PR, see description and 7b5cc9f commit message:
- update fetch call to pass in data source id
- data source id is always undefined because log explorer doesn't support multi-datasource. passing undefined fixes the parameters so UI shows PPL errors in toasts
sejli
approved these changes
Sep 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 7aa554a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 7aa554a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Sep 10, 2024
(cherry picked from commit 7aa554a) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
pushed a commit
that referenced
this pull request
Sep 10, 2024
(cherry picked from commit 7aa554a) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has these fixes
prependproperty the icon will be smaller than its original size, but since the text field is nowcompactand original size doesn't fit anymore, we can revert back to useprepend.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.