Fix integration imports for table and card view #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha and
TackAdam
as code owners
TackAdam
approved these changes
Sep 9, 2024
joshuali925
approved these changes
Sep 9, 2024
| @@ -94,7 +94,7 @@ export function AddedIntegrationsTable(props: AddedIntegrationsTableProps) { | |||
| truncateText: true, | |||
| render: (value, record) => ( | |||
| <EuiText data-test-subj={`${record.templateName}IntegrationDescription`}> | |||
| {truncate(record.dataSourceMDSLabel || 'Local cluster', { length: 100 })} | |||
| {_.truncate(record.dataSourceMDSLabel || 'Local cluster', { length: 100 })} | |||
There was a problem hiding this comment.
there was a PR to remove importing full lodash library, does this increase loaded javascript size for users?
There was a problem hiding this comment.
That lodash PR wasn't backported, hence there was this import issue when the MDS PR was being backported.
RyanL1997
approved these changes
Sep 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 7a63a9e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 7a63a9e) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Latest Observability on 2.x/2.17 fails to load the integrations plugin due to import error.
Issues Resolved
Fix integration imports for table and card view
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.