Fix getting started cards re-direction to integrations #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
joshuali925
approved these changes
Sep 9, 2024
| onClick={() => | ||
| coreRefs?.application?.navigateToApp(observabilityIntegrationsID, { | ||
| path: `#/available/${integration.name}`, | ||
| }) |
There was a problem hiding this comment.
using onclick user won't be able to open link in new tab, can this use http.basePath.get()? but not a big issue since it's getting started page
There was a problem hiding this comment.
UX perspective is to load integrations in-place in the same tab.
RyanL1997
approved these changes
Sep 9, 2024
|
Tested with and without workspaces enabled, both working. WorkspaceEnabled.mov |
TackAdam
approved these changes
Sep 9, 2024
derek-ho
approved these changes
Sep 9, 2024
YANG-DB
approved these changes
Sep 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 279463a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 279463a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 279463a) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 279463a) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today getting started plugin uses href to navigate to integrations plugin using the EuiCards for integrations catalog. This becomes an issue when
workspacesis enabled in OSD core as workspaces relies on url in browser for saved object scoping.Issues Resolved
Removed the
hrefcall and replaced it withnavigateToAppfrom core.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.