[Page Header] New page header for notebooks and UI updates #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Icon size adjusted to match reporting. |
Signed-off-by: Adam Tackett <tackadam@amazon.com>
sumukhswamy
reviewed
Aug 28, 2024
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
|
Fixed eui call out for upgrade to span full page |
sumukhswamy
approved these changes
Aug 28, 2024
ps48
approved these changes
Aug 28, 2024
ps48
reviewed
Aug 28, 2024
| maxWidth: '1500px', | ||
| const newNavigation = coreRefs.chrome?.navGroup.getNavGroupEnabled(); | ||
|
|
||
| const panelStyles: CSS.Properties = { |
There was a problem hiding this comment.
Not a blocker: not a fan of custom css when we could have an EuiSpacer
ps48
reviewed
Aug 28, 2024
| </EuiFlexItem> | ||
| <EuiFlexItem grow={true} /> |
There was a problem hiding this comment.
With:
Without:
Certain page sizes caused it to collapse to the left and not maintain the look of the rest of the page without the flex item.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
* starting notebooks rework Signed-off-by: Adam Tackett <tackadam@amazon.com> * rework notebooks ui and jest testing Signed-off-by: Adam Tackett <tackadam@amazon.com> * handle emptystate badge Signed-off-by: Adam Tackett <tackadam@amazon.com> * update some cypress ui fixes Signed-off-by: Adam Tackett <tackadam@amazon.com> * add snapshots, remove flaky query assist test Signed-off-by: Adam Tackett <tackadam@amazon.com> * add datatest subject to h3 tittle Signed-off-by: Adam Tackett <tackadam@amazon.com> * put back the gettingstartedID registrations Signed-off-by: Adam Tackett <tackadam@amazon.com> * make the callout for upgrading old notebooks span full page Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> (cherry picked from commit ce0d14c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
pushed a commit
that referenced
this pull request
Aug 28, 2024
…2106) * starting notebooks rework * rework notebooks ui and jest testing * handle emptystate badge * update some cypress ui fixes * add snapshots, remove flaky query assist test * add datatest subject to h3 tittle * put back the gettingstartedID registrations * make the callout for upgrading old notebooks span full page --------- (cherry picked from commit ce0d14c) Signed-off-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Navigation before:
New navigation after:
Old Navigation before:
After changes:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.