Use smaller and compressed varients of buttons and form components #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
SuZhou-Joe
approved these changes
Aug 17, 2024
Hailong-am
approved these changes
Aug 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
) * Use EuiSmallButton Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonEmpty Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedFormRow Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedField* Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedComboBox Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallFilterButton Signed-off-by: Miki <miki@amazon.com> * Update snapshots and tests Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit a5066a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 20, 2024
) * Use EuiSmallButton Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonEmpty Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedFormRow Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedField* Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedComboBox Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallFilterButton Signed-off-by: Miki <miki@amazon.com> * Update snapshots and tests Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit a5066a9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Aug 20, 2024
) (#238) * Use EuiSmallButton * Use EuiSmallButtonEmpty * Use EuiCompressedFormRow * Use EuiCompressedField* * Use EuiCompressedSelect and EuiCompressedSuperSelect * Use EuiCompressedRadio and EuiCompressedRadioGroup * Use EuiCompressedEuiTextArea * Use EuiCompressedComboBox * Use EuiSmallFilterButton * Update snapshots and tests --------- (cherry picked from commit a5066a9) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace instances of
EuiButtonthat don't have an explicit sizing attribute toEuiSmallButton*.Replace instances of
Eui<form elements>that don't have density attributes toEuiCompressed<form elements>.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.