-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces refresh option to update the custom vector map list #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
junqiu-lei
previously approved these changes
Jun 27, 2022
navneet1v
reviewed
Jun 27, 2022
...lugins/custom_import_map/public/components/__snapshots__/vector_upload_options.test.tsx.snap
Outdated
Show resolved
Hide resolved
...lugins/custom_import_map/public/components/__snapshots__/vector_upload_options.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/plugins/custom_import_map/public/components/vector_upload_options.tsx
Show resolved
Hide resolved
src/plugins/custom_import_map/public/components/vector_upload_options.test.tsx
Outdated
Show resolved
Hide resolved
navneet1v
reviewed
Jun 27, 2022
src/plugins/custom_import_map/public/components/vector_upload_options.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 90.83% 90.57% -0.26%
==========================================
Files 5 5
Lines 131 138 +7
Branches 20 22 +2
==========================================
+ Hits 119 125 +6
- Misses 8 9 +1
Partials 4 4
Continue to review full report at Codecov.
|
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
navneet1v
reviewed
Jun 29, 2022
src/plugins/custom_import_map/public/components/vector_upload_options.tsx
Show resolved
Hide resolved
src/plugins/custom_import_map/public/components/vector_upload_options.tsx
Show resolved
Hide resolved
navneet1v
approved these changes
Jun 29, 2022
junqiu-lei
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivam Dhar dhshivam@amazon.com
Description
The PR adds refresh button to the toasts to update component props before visualizing the uploaded custom vector map.
The refresh button is seen right after the geoJSON file is imported by the user when all the features that are part of the geoJSON file are indexed completely or partially. In case of any other failure, the refresh button won't be shown - as there is no change in the custom vector map list.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.