Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces refresh option to update the custom vector map list #14

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

Shivamdhar
Copy link
Contributor

@Shivamdhar Shivamdhar commented Jun 27, 2022

Signed-off-by: Shivam Dhar dhshivam@amazon.com

Description

The PR adds refresh button to the toasts to update component props before visualizing the uploaded custom vector map.
The refresh button is seen right after the geoJSON file is imported by the user when all the features that are part of the geoJSON file are indexed completely or partially. In case of any other failure, the refresh button won't be shown - as there is no change in the custom vector map list.

Screen Shot 2022-06-28 at 4 57 31 PM Screen Shot 2022-06-28 at 4 57 59 PM

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
@Shivamdhar Shivamdhar requested a review from a team June 27, 2022 16:36
junqiu-lei
junqiu-lei previously approved these changes Jun 27, 2022
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #14 (3a7fbd9) into main (0b3296c) will decrease coverage by 0.25%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   90.83%   90.57%   -0.26%     
==========================================
  Files           5        5              
  Lines         131      138       +7     
  Branches       20       22       +2     
==========================================
+ Hits          119      125       +6     
- Misses          8        9       +1     
  Partials        4        4              
Impacted Files Coverage Δ
..._import_map/public/components/show_error_modal.tsx 100.00% <ø> (ø)
...rt_map/public/components/vector_upload_options.tsx 90.26% <91.66%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3296c...3a7fbd9. Read the comment docs.

Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
@Shivamdhar Shivamdhar merged commit 4e20a48 into opensearch-project:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants