Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local staging maven jars publishing and add custom build.sh #27

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Sep 8, 2023

Description

Add local staging maven jars publishing and add custom build.sh

Issues Resolved

opensearch-project/opensearch-build#3743
opensearch-project/opensearch-build#3971

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon self-assigned this Sep 8, 2023
@peterzhuamazon peterzhuamazon changed the title Add local staging maven jars publishing Add local staging maven jars publishing and add custom build.sh Sep 8, 2023
@peterzhuamazon
Copy link
Member Author


[~/opensearch-build-peterzhuamazon/tar/builds/opensearch/maven/org/opensearch]
% ls plugin/custom-codecs/2.10.0.0
custom-codecs-2.10.0.0.pom      custom-codecs-2.10.0.0.pom.sha1    custom-codecs-2.10.0.0.pom.sha512  custom-codecs-2.10.0.0.zip.md5   custom-codecs-2.10.0.0.zip.sha256
custom-codecs-2.10.0.0.pom.md5  custom-codecs-2.10.0.0.pom.sha256  custom-codecs-2.10.0.0.zip         custom-codecs-2.10.0.0.zip.sha1  custom-codecs-2.10.0.0.zip.sha512

[~/opensearch-build-peterzhuamazon/tar/builds/opensearch/maven/org/opensearch]
% ls opensearch-custom-codecs/2.10.0.0
opensearch-custom-codecs-2.10.0.0.jar         opensearch-custom-codecs-2.10.0.0-javadoc.jar         opensearch-custom-codecs-2.10.0.0.module         opensearch-custom-codecs-2.10.0.0.pom         opensearch-custom-codecs-2.10.0.0-sources.jar
opensearch-custom-codecs-2.10.0.0.jar.md5     opensearch-custom-codecs-2.10.0.0-javadoc.jar.md5     opensearch-custom-codecs-2.10.0.0.module.md5     opensearch-custom-codecs-2.10.0.0.pom.md5     opensearch-custom-codecs-2.10.0.0-sources.jar.md5
opensearch-custom-codecs-2.10.0.0.jar.sha1    opensearch-custom-codecs-2.10.0.0-javadoc.jar.sha1    opensearch-custom-codecs-2.10.0.0.module.sha1    opensearch-custom-codecs-2.10.0.0.pom.sha1    opensearch-custom-codecs-2.10.0.0-sources.jar.sha1
opensearch-custom-codecs-2.10.0.0.jar.sha256  opensearch-custom-codecs-2.10.0.0-javadoc.jar.sha256  opensearch-custom-codecs-2.10.0.0.module.sha256  opensearch-custom-codecs-2.10.0.0.pom.sha256  opensearch-custom-codecs-2.10.0.0-sources.jar.sha256
opensearch-custom-codecs-2.10.0.0.jar.sha512  opensearch-custom-codecs-2.10.0.0-javadoc.jar.sha512  opensearch-custom-codecs-2.10.0.0.module.sha512  opensearch-custom-codecs-2.10.0.0.pom.sha512  opensearch-custom-codecs-2.10.0.0-sources.jar.sha512

@reta
Copy link
Collaborator

reta commented Sep 8, 2023

@peterzhuamazon thanks but why we need Jenkins since we have GH workflow for it (that all other repos use)? We will need to copy/paste the script all over the place :(

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Sep 8, 2023

@peterzhuamazon thanks but why we need Jenkins since we have GH workflow for it (that all other repos use)? We will need to copy/paste the script all over the place :(

This is release maven even though the name says staging local.
It will be copied to S3 and will be published to maven central when 2.10.0 release.
Sorry for the confusing naming tho.

Also waiting for this from you to get merged beforehand:

Thanks.

@reta
Copy link
Collaborator

reta commented Sep 8, 2023

@peterzhuamazon thanks but why we need Jenkins since we have GH workflow for it (that all other repos use)? We will need to copy/paste the script all over the place :(

Got the answer, this is the release workflows

@reta
Copy link
Collaborator

reta commented Sep 8, 2023

Please hold on till #26 gets in to have the right articfat names

@@ -43,7 +42,7 @@ repositories {
}

allprojects {
group 'org.opensearch.plugin'
group 'org.opensearch'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be under plugin.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it should be non-plugin for all project, and plugin for only the plugin zip.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a sec, for plugins we publish -client artifacts and they are all under org.opensearch.plugin, for example:

https://mvnrepository.com/artifact/org.opensearch.plugin/ingest-attachment/2.9.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For info, looked with @peterzhuamazon : for non-core plugins, JAR artifacts go under org.opensearch but ZIP artifacts go under org.opensearch.plugin. For core plugins, everything goes under org.opensearch.plugin

@reta reta merged commit 888cf7b into opensearch-project:main Sep 8, 2023
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 888cf7b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 888cf7b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peterzhuamazon peterzhuamazon deleted the add-local-staging-maven-local-jars branch September 8, 2023 19:38
andrross pushed a commit that referenced this pull request Sep 8, 2023
(cherry picked from commit 888cf7b)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Sep 8, 2023
(cherry picked from commit 888cf7b)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants