AD model performance benchmark #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
force-pushed
the
precision_1.3
branch
from
739667f
to
e419f53
Compare
Codecov Report
@@ Coverage Diff @@
## 1.3 #722 +/- ##
============================================
+ Coverage 77.66% 77.97% +0.31%
- Complexity 4110 4133 +23
============================================
Files 296 296
Lines 17673 17687 +14
Branches 1882 1884 +2
============================================
+ Hits 13725 13791 +66
+ Misses 3041 2999 -42
+ Partials 907 897 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
force-pushed
the
precision_1.3
branch
from
e419f53
to
21e8f42
Compare
This PR adds a HCAD model performance benchmark so that we can compare model performance across versions. Regarding benchmark data, we randomly generated synthetic data with known anomalies inserted throughout the signal. In particular, these are one/two/four dimensional data where each dimension is a noisy cosine wave. Anomalies are inserted into one dimension with 0.003 probability. Anomalies across each dimension can be independent or dependent. We have approximately 5000 observations per data set. The data set is generated using the same random seed so the result is comparable across versions. We also backported opensearch-project#600 so that we can capture the performance data in CI output. Testing done: * added unit tests to run the benchmark. Signed-off-by: Kaituo Li <kaituo@amazon.com>
kaituo
force-pushed
the
precision_1.3
branch
from
21e8f42
to
05b18ad
Compare
amitgalitz
reviewed
Nov 17, 2022
| @@ -670,6 +692,7 @@ dependencies { | |||
| testImplementation 'org.junit.jupiter:junit-jupiter-engine:5.7.2' | |||
| testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.7.2' | |||
| testCompileOnly 'junit:junit:4.13.2' | |||
| implementation group: 'org.javassist', name: 'javassist', version:'3.28.0-GA' | |||
There was a problem hiding this comment.
Did you figure out why we suddenly needed this?
There was a problem hiding this comment.
I didn't. The 1.3 CI started failing due to missing javassit since Oct 5.
ohltyler
reviewed
Nov 17, 2022
ohltyler
reviewed
Nov 17, 2022
amitgalitz
approved these changes
Nov 17, 2022
ohltyler
approved these changes
Nov 17, 2022
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-722-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 42095db3e08a767906b269a640080e6c62921c89
# Push it to GitHub
git push --set-upstream origin backport/backport-722-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an AD model performance benchmark so that we can compare model performance across versions.
For the single stream detector, we refactored tests in DetectionResultEvalutationIT and moved it to SingleStreamModelPerfIT.
For the HCAD detector, we randomly generated synthetic data with known anomalies inserted throughout the signal. In particular, these are one/two/four dimensional data where each dimension is a noisy cosine wave. Anomalies are inserted into one dimension with 0.003 probability. Anomalies across each dimension can be independent or dependent. We have approximately 5000 observations per data set. The data set is generated using the same random seed so the result is comparable across versions.
We also backported #600 so that we can capture the performance data in CI output.
Testing done:
Signed-off-by: Kaituo Li kaituo@amazon.com
Issues Resolved
#719
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.