-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BWC zip links #625
Update BWC zip links #625
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
We have similar issue as in opensearch-project/OpenSearch#3001 Might want to try to use 1.0.1 instead of 1.0.0 |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Hmm, seems 1.0.1 is not published:
|
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Since there is no components on version 1.0.1.x besides the security patched zip, including OpenSearch / OpenSearch Dashboards, it's inaccessible. Confirming if we should move to 1.1.0, or find a workaround to get the patched security zip. |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
This will fail as 1.1 zips are not available at that link yet. Will re-run once the decision to move to 1.1 is finalized and zips are available. |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Hhistorical detector creation is failing for BWC, still investigating. Likely it's some of the historical detector refactoring changes between ODFE 1.13/OpenSearch 1.0.0 -> OpenSearch 1.1.0.
|
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #625 +/- ##
============================================
- Coverage 79.07% 78.99% -0.09%
- Complexity 4213 4234 +21
============================================
Files 296 301 +5
Lines 17686 17869 +183
Branches 1880 1894 +14
============================================
+ Hits 13986 14116 +130
- Misses 2805 2847 +42
- Partials 895 906 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-625-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f846016c92800383ed848936ed82251108c8947
# Push it to GitHub
git push --set-upstream origin backport/backport-625-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 7f84601)
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 7f84601)
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
Update BWC links to point to OpenSearch 1.1.0, since Open Distro is now officially unsupported. See OpenSearch maintenance policy on supported versions.
This PR also cleans up BWC tests to be compatible with 1.1 as the baseline. Note there was some changes to historical analysis between ODFE 1.13.0.0 (based on ES 7.10.2) => OpenSearch 1.1.0.0.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.