Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adding Alerting Comments system indices and Security ITs (#1659) #1686

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

toepkerd
Copy link
Contributor

@toepkerd toepkerd commented Oct 2, 2024

  • Adding Alerting Comments system indices

Signed-off-by: Dennis Toepker toepkerd@amazon.com

  • Add security ITs for Alerting Comments

Signed-off-by: Dennis Toepker toepkerd@amazon.com

  • removed unused imports

Signed-off-by: Dennis Toepker toepkerd@amazon.com

  • uncomment system index viewing IT

Signed-off-by: Dennis Toepker toepkerd@amazon.com

  • uncommenting system index IT for now

Signed-off-by: Dennis Toepker toepkerd@amazon.com

  • adding IT for admin editting someone else's comment

Signed-off-by: Dennis Toepker toepkerd@amazon.com


Signed-off-by: Dennis Toepker toepkerd@amazon.com
Co-authored-by: Dennis Toepker toepkerd@amazon.com
(cherry picked from commit d8f47a0)

Description

Backport of PR #1659 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…project#1659)

* Adding Alerting Comments system indices

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* Add security ITs for Alerting Comments

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* removed unused imports

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* uncomment system index viewing IT

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* uncommenting system index IT for now

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adding IT for admin editting someone else's comment

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

---------

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
(cherry picked from commit d8f47a0)
@toepkerd
Copy link
Contributor Author

toepkerd commented Oct 2, 2024

WhiteSource Security Check CI failing due to what appears to be a connectivity issue:

Oops! An error occurred while running the Security Check.The Scanner was unable to connect to the repository or branch and clone it.

@toepkerd toepkerd marked this pull request as ready for review October 2, 2024 22:48
@AWSHurneyt AWSHurneyt changed the title Adding Alerting Comments system indices and Security ITs (#1659) [Backport 2.x] Adding Alerting Comments system indices and Security ITs (#1659) Oct 2, 2024
@jowg-amazon jowg-amazon merged commit 781cb0e into opensearch-project:2.x Oct 2, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants