Upgrade github workflow upload artifact to v3 #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joanne Wang <jowg@amazon.com>
jowg-amazon
force-pushed
the
upload_artifact
branch
from
469854d
to
6fc4a5e
Compare
jowg-amazon
changed the title
jowg-amazon
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn,
amsiglan and
goyamegh
as code owners
AWSHurneyt
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
@jowg-amazon If possible, could you also have someone from the release team take a look at this PR to make sure it's correct?
riysaxen-amzn
approved these changes
Sep 10, 2024
eirsep
approved these changes
Sep 10, 2024
@gaiksaya confirmed that changing this version doesn't affect any release related artifacts and other plugins are also currently on v3 (ex. https://github.com/opensearch-project/job-scheduler/blob/1c282b0342183a743e166af9650b7c0bde68a11c/.github/workflows/ci.yml#L55) |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit e113dbb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit e113dbb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 17, 2024
(cherry picked from commit e113dbb) Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 18, 2024
(cherry picked from commit e113dbb) Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit e113dbb) Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 01a2f64) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit e113dbb) Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 01a2f64) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sbcd90
pushed a commit
that referenced
this pull request
Sep 26, 2024
sbcd90
pushed a commit
that referenced
this pull request
Sep 26, 2024
sbcd90
pushed a commit
to sbcd90/alerting
that referenced
this pull request
Sep 26, 2024
…roject#1658) (opensearch-project#1677) Signed-off-by: Joanne Wang <jowg@amazon.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upload-artifact@v1 and upload-artifact@v2 was deprecated. This pr upgrades the github test workflow
upload-artifactfrom @v1 to @V3.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.