Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.15] [Backport 2.x] Alerting Enhancements: Alerting Comments (Experimental) (#1561) #1573

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f52eb2a from #1572.

#1561) (#1572)

* Alerting Enhancements: Alerting Comments (Experimental) (#1561)

* initial commit, functional but needs refactoring

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* refactored QueryLevelTriggerExecutionContext to not need both Alert and AlertContext field, but only AlertContext field

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc additions and fixes

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc cleanup

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc changes and basic ITs

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* cleanup

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* renaming notes to comments

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc changes

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* changed API endpoints

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* more misc changes and fixes

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc cleanup

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* updated a comment

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc cleanup and setting refresh policy to immediate

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* fixed lint issues and other restructuring

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* review-based changes

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* update after adding entityType to Comment model

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* misc fixes

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* removing comments history enabled setting

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* adding release notes

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* IT fixes

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* removing dev code vestiges

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

* changing logger calls

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

---------

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>

* fixed imports

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>

---------

Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
(cherry picked from commit f52eb2a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jowg-amazon jowg-amazon merged commit 9d6005c into 2.15 Jun 12, 2024
12 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants