Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1097, 1302, 1435, 1441, 1445, 1430 #1470

Merged
merged 9 commits into from
Mar 14, 2024

Conversation

engechas
Copy link
Collaborator

@engechas engechas commented Mar 13, 2024

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

lezzago and others added 4 commits March 13, 2024 12:23
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
…arch-project#1302)

* optimize doc-level monitor execution for datastreams

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* add more tests to address comments

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* add integTest for multiple datastreams inside a single index pattern

* add integTest for multiple datastreams inside a single index pattern

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

---------

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@engechas engechas mentioned this pull request Mar 14, 2024
1 task
eirsep and others added 4 commits March 13, 2024 22:43
… percolate queries (opensearch-project#1435)

* add jvm aware and max docs settings for batching docs for percolate queries

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix stats logging

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* add queryfieldnames field in findings mapping

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
…vel monitor instead of entire _source for each doc (opensearch-project#1441)

* optimize to fetch only fields relevant to doc level queries in doc level monitor

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix test for settings check

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix ktlint

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
…c level monitor execution (opensearch-project#1445)

* optimize sequence number calculation and reduce search requests by n where n is number of shards being queried in the executino

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix tests

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* optimize check indices and execute to query only write index of aliases and datastreams during monitor creation

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix test

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* add javadoc

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* add tests to verify seq_no calculation

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
@engechas engechas changed the title Fix 2.5 build by moving BWC tests to use zipArchives + match format in main Backport 1097, 1302, 1435, 1441, 1445, 1430 Mar 14, 2024
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 82.40575% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 76.22%. Comparing base (5f738e3) to head (be34ced).
Report is 10 commits behind head on 2.5.

Files Patch % Lines
.../opensearch/alerting/DocumentLevelMonitorRunner.kt 80.20% 36 Missing and 23 partials ⚠️
...opensearch/alerting/util/DocLevelMonitorQueries.kt 84.84% 7 Missing and 18 partials ⚠️
.../org/opensearch/alerting/MonitorMetadataService.kt 37.50% 0 Missing and 5 partials ⚠️
.../kotlin/org/opensearch/alerting/util/IndexUtils.kt 72.22% 1 Missing and 4 partials ⚠️
...in/org/opensearch/alerting/MonitorRunnerService.kt 89.47% 2 Missing ⚠️
.../alerting/transport/TransportIndexMonitorAction.kt 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.5    #1470      +/-   ##
============================================
+ Coverage     75.76%   76.22%   +0.45%     
  Complexity      116      116              
============================================
  Files           125      125              
  Lines          6851     7320     +469     
  Branches       1028     1104      +76     
============================================
+ Hits           5191     5580     +389     
- Misses         1132     1178      +46     
- Partials        528      562      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@engechas engechas merged commit adac5fd into opensearch-project:2.5 Mar 14, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants