Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1325 to 2.4 #1376

Open
wants to merge 2 commits into
base: 2.4
Choose a base branch
from

Conversation

engechas
Copy link
Collaborator

Issue #, if available: opensearch-project/security-analytics#718

Description of changes:
Manually resolves backport of #1325

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

engechas and others added 2 commits January 16, 2024 14:38
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a85f26) 76.28% compared to head (ebc6901) 76.15%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.4    #1376      +/-   ##
============================================
- Coverage     76.28%   76.15%   -0.14%     
  Complexity      116      116              
============================================
  Files           124      124              
  Lines          6617     6618       +1     
  Branches        982      983       +1     
============================================
- Hits           5048     5040       -8     
- Misses         1068     1080      +12     
+ Partials        501      498       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants