Fix store type settings ordering for searchable snapshots #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotwanikunal
added
backport 2.x
kotwanikunal
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
kotwanikunal
changed the title
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
kotwanikunal
force-pushed
the
fix-index-setting-bug
branch
from
e4a3522
to
7421127
Compare
kotwanikunal
commented
Apr 25, 2023
| @@ -334,6 +342,7 @@ private void createIndexWithDocsAndEnsureGreen(int numReplicasIndex, int numOfDo | |||
| Settings.builder() | |||
| .put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, Integer.toString(numReplicasIndex)) | |||
| .put(IndexMetadata.SETTING_NUMBER_OF_SHARDS, "1") | |||
| .put(IndexModule.INDEX_STORE_TYPE_SETTING.getKey(), IndexModule.Type.FS.getSettingsKey()) | |||
There was a problem hiding this comment.
Added this setting for ensuring store type is set to the correct value at restore.
Verified that assertRemoteSnapshotIndexSettings fails if the ordering within RestoreService is not flipped.
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7297 +/- ##
=========================================
Coverage 70.65% 70.66%
- Complexity 59515 59545 +30
=========================================
Files 4862 4862
Lines 285544 285544
Branches 41153 41153
=========================================
+ Hits 201749 201774 +25
- Misses 67182 67205 +23
+ Partials 16613 16565 -48
... and 511 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
andrross
approved these changes
Apr 25, 2023
|
Flaky test documented here: #6124 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> (cherry picked from commit 72ed13b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> (cherry picked from commit 72ed13b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
42 tasks
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Apr 28, 2023
…search-project#7297) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…search-project#7297) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
index.store.typeleads to wrong ordering for store type settings, causing the restore to be of the original configuration set on the index at backup which can befs/ a local restored index instead. (Sample code which does that with benchmarks here)Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.