[Backport 1.3] Bugfix: Allow opensearch.bat file and opensearch-env.bat files to run when install path includes a space. #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when install path includes a space. (opensearch-project#4362) * Bugfix: Prevent escaping of in `else-if` statement by setting variable without double quotes. Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> * Add changelog entry for fix Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> * Escape double quotes for environment variables set by `opensearch-env.bat`. Explicitly apply quotes where those environment variables are invoked. Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> Signed-off-by: Mike Wilkinson <mwilkinson@imohealth.com> Co-authored-by: Mike Wilkinson <mwilkinson@imohealth.com> Signed-off-by: Xue Zhou <xuezhou@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 1.3 #5474 +/- ##
============================================
- Coverage 77.92% 77.90% -0.03%
+ Complexity 63450 63439 -11
============================================
Files 4454 4454
Lines 274943 274943
Branches 41166 41166
============================================
- Hits 214261 214204 -57
- Misses 43779 43840 +61
+ Partials 16903 16899 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tlfeng
approved these changes
Dec 7, 2022
peterzhuamazon
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xue Zhou xuezhou@amazon.com
Description
[Backport 1.3] Bugfix: Allow opensearch.bat file and opensearch-env.bat files to run when install path includes a space.
Issues Resolved
#4362
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.