Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix Flaky Tests testReplicaThreadedUpdateToShardLimitsAndRejections and testCoordinatingPrimaryThreadedUpdateToShardLimitsAndRejections #5450

Merged
merged 1 commit into from
Dec 5, 2022
Merged

[Backport 2.x] Fix Flaky Tests testReplicaThreadedUpdateToShardLimitsAndRejections and testCoordinatingPrimaryThreadedUpdateToShardLimitsAndRejections #5450

merged 1 commit into from
Dec 5, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0bd3141 from #5439.

@github-actions
Fix flaky ShardIndexingPressureConcurrentExecutionTests (#5439)
bd6c0bb 
Add conditional check on assertNull to fix flaky tests.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
(cherry picked from commit 0bd3141)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners December 5, 2022 17:35
@codecov-commenter
Copy link

Codecov Report

Merging #5450 (0bd3141) into 2.x (44e9343) will increase coverage by 0.42%.
The diff coverage is 50.62%.

❗ Current head 0bd3141 differs from pull request most recent head bd6c0bb. Consider uploading reports for the commit bd6c0bb to get more accurate results

@@             Coverage Diff              @@
##                2.x    #5450      +/-   ##
============================================
+ Coverage     70.56%   70.98%   +0.42%     
+ Complexity    58281    58125     -156     
============================================
  Files          4700     4711      +11     
  Lines        279092   277573    -1519     
  Branches      40751    40180     -571     
============================================
+ Hits         196939   197035      +96     
+ Misses        65767    64392    -1375     
+ Partials      16386    16146     -240
Impacted Files Coverage Δ
...ark/time/NanoTimeVsCurrentTimeMillisBenchmark.java 0.00% <0.00%> (ø)
...nsearch/gradle/precommit/LicenseHeadersTask.groovy 0.00% <ø> (ø)
.../java/org/opensearch/gradle/JdkDownloadPlugin.java 36.26% <0.00%> (-1.10%) ⬇️
...rg/opensearch/gradle/OpenSearchTestBasePlugin.java 6.81% <0.00%> (-0.25%) ⬇️
...ternal/InternalDistributionArchiveCheckPlugin.java 0.00% <0.00%> (ø)
...ternal/InternalDistributionArchiveSetupPlugin.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/FilePermissionsTask.java 78.78% <ø> (ø)
...search/gradle/precommit/ForbiddenPatternsTask.java 88.40% <ø> (ø)
...g/opensearch/gradle/precommit/LoggerUsageTask.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/ThirdPartyAuditTask.java 0.00% <0.00%> (ø)
... and 1005 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit 1be8521 into 2.x Dec 5, 2022
@github-actions github-actions bot deleted the backport/backport-5439-to-2.x branch December 5, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codecov-commenter @andrross @Rishikesh1159