Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add validation for the search backpressure cancellation settings #15969

Merged

Merge remote-tracking branch 'upstream/2.x' into backport/backport-15…

34e958a
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] Add validation for the search backpressure cancellation settings #15969

Merge remote-tracking branch 'upstream/2.x' into backport/backport-15…
34e958a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 0s

71.76% (target 70.00%)

View this Pull Request on Codecov

71.76% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (bfdc30c) to head (34e958a).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...kpressure/settings/SearchBackpressureSettings.java 25.00% 3 Missing and 3 partials ⚠️
...backpressure/settings/SearchShardTaskSettings.java 75.00% 1 Missing and 1 partial ⚠️
...arch/backpressure/settings/SearchTaskSettings.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15969      +/-   ##
============================================
+ Coverage     71.67%   71.76%   +0.08%     
- Complexity    64624    64705      +81     
============================================
  Files          5276     5276              
  Lines        302298   302332      +34     
  Branches      43992    43995       +3     
============================================
+ Hits         216674   216961     +287     
+ Misses        67532    67232     -300     
- Partials      18092    18139      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.