Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow snapshot v2 - create snapshot validations in a cluster state update #15939

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Sep 16, 2024

Description

  1. Adding IN_PROGRESS cluster state entry for shallow v2 snapshots. Associated clean up with this. This ensure whatever validations we are doing are atomic in nature.
  2. Pinning timestamp before doing finalize snapshot .
  3. Blocking concurrent v2 snapshots.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 1a9da53: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for cc61ad4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 16063da: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e69972b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 46b5e1f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f1cac50: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a948ec0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dce4359: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 7b8b9c6: SUCCESS

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 34.70588% with 111 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (7caca26) to head (5028938).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 31.54% 96 Missing and 6 partials ⚠️
...va/org/opensearch/cluster/SnapshotsInProgress.java 57.14% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15939      +/-   ##
============================================
- Coverage     72.04%   71.90%   -0.14%     
+ Complexity    64441    64390      -51     
============================================
  Files          5281     5281              
  Lines        301088   301191     +103     
  Branches      43500    43518      +18     
============================================
- Hits         216918   216575     -343     
- Misses        66438    66831     +393     
- Partials      17732    17785      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna marked this pull request as ready for review September 25, 2024 08:48
@sachinpkale sachinpkale changed the title Shallow snapshot v2 - do create snapshot validations in a cluster sta… Shallow snapshot v2 - create snapshot validations in a cluster state update Sep 26, 2024
Copy link
Contributor

❌ Gradle check result for e54858c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0382146: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a8cbefc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…te update

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Copy link
Contributor

✅ Gradle check result for 5028938: SUCCESS

@sachinpkale sachinpkale merged commit e8b02c9 into opensearch-project:main Sep 27, 2024
32 of 34 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Sep 27, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 27, 2024
…update (#15939)

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit e8b02c9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Sep 30, 2024
…update (#15939) (#16102)

---------


(cherry picked from commit e8b02c9)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hainenber pushed a commit to hainenber/OpenSearch that referenced this pull request Oct 1, 2024
…update (opensearch-project#15939)

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants