Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Add Update QueryGroup API Logic (#14775) #15707

Conversation

ruai0511
Copy link
Contributor

@ruai0511 ruai0511 commented Sep 4, 2024

Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* Add Update QueryGroup API Logic
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* append to changlog
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add javadoc
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* rebase
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* fix UT
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* adress comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
(cherry picked from commit 0753461)
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for eaa2718: SUCCESS

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 82.20339% with 42 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (a3312b4) to head (eaa2718).
Report is 2 commits behind head on 2.17.

Files with missing lines Patch % Lines
.../org/opensearch/wlm/MutableQueryGroupFragment.java 87.50% 7 Missing and 5 partials ⚠️
...ch/plugin/wlm/rest/RestUpdateQueryGroupAction.java 0.00% 8 Missing ⚠️
...in/wlm/action/TransportUpdateQueryGroupAction.java 0.00% 5 Missing ⚠️
...va/org/opensearch/cluster/metadata/QueryGroup.java 86.48% 2 Missing and 3 partials ⚠️
...rch/plugin/wlm/action/UpdateQueryGroupRequest.java 73.33% 4 Missing ⚠️
...ugin/wlm/service/QueryGroupPersistenceService.java 92.85% 2 Missing and 2 partials ⚠️
...arch/plugin/wlm/action/UpdateQueryGroupAction.java 0.00% 3 Missing ⚠️
...pensearch/plugin/wlm/WorkloadManagementPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15707      +/-   ##
============================================
- Coverage     71.70%   71.64%   -0.06%     
- Complexity    64192    64257      +65     
============================================
  Files          5251     5257       +6     
  Lines        300493   300650     +157     
  Branches      43728    43738      +10     
============================================
- Hits         215465   215398      -67     
- Misses        66974    67211     +237     
+ Partials      18054    18041      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit 0fd6a6a into opensearch-project:2.17 Sep 5, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants