Initialize RemoteRoutingTableService when we have RoutingTableRepos #15645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiv0408
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sarthakaggarwal97
approved these changes
Sep 4, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
force-pushed
the
rrt-service
branch
from
c83f005
to
f605f1c
Compare
|
❌ Gradle check result for c83f005: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15645 +/- ##
============================================
- Coverage 71.90% 71.85% -0.06%
- Complexity 64086 64088 +2
============================================
Files 5269 5269
Lines 299807 299807
Branches 43326 43326
============================================
- Hits 215581 215419 -162
- Misses 66493 66666 +173
+ Partials 17733 17722 -11 ☔ View full report in Codecov by Sentry. |
Bukhtawar
approved these changes
Sep 4, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…tory configured (opensearch-project#15645) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were earlier depending of RemotePublicationEnabled flag on all nodes to Initializing the RemoteRoutingTableService. But, this can cause issues when we are trying to disable or enable the RemotePublication. We should rather just depend on Routing Table Repos only to decide if we want to initialize the InternalRemoteRoutingTableService or NoopRoutingTableService.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.