Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Modify create snapshot v2 response when wait_for_completion is false #15615

Merged

Conversation

anshu1106
Copy link
Contributor

Description

Backport for #15499

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@anshu1106 anshu1106 changed the base branch from main to 2.x September 3, 2024 15:21
…n is false

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 9b5d66d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for 62e943c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for ff8835b: SUCCESS

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (62e943c) to head (ff8835b).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...napshots/create/TransportCreateSnapshotAction.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15615      +/-   ##
============================================
- Coverage     71.68%   71.65%   -0.04%     
+ Complexity    64023    63925      -98     
============================================
  Files          5243     5243              
  Lines        299319   299321       +2     
  Branches      43568    43569       +1     
============================================
- Hits         214566   214467      -99     
- Misses        66820    66887      +67     
- Partials      17933    17967      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants