Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Extract replicator logic from SegmentReplicationTargetService #15540

Merged
merged 1 commit into from
Sep 1, 2024

Extract replicator logic from SegmentReplicationTargetService (#15511)

31980f3
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] Extract replicator logic from SegmentReplicationTargetService #15540

Extract replicator logic from SegmentReplicationTargetService (#15511)
31980f3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 31, 2024 in 1s

71.66% (target 70.00%)

View this Pull Request on Codecov

71.66% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (a2b6f8c) to head (31980f3).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...nsearch/indices/replication/SegmentReplicator.java 77.58% 9 Missing and 4 partials ⚠️
...s/replication/SegmentReplicationTargetService.java 64.28% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15540      +/-   ##
============================================
- Coverage     71.73%   71.66%   -0.07%     
+ Complexity    63721    63717       -4     
============================================
  Files          5235     5236       +1     
  Lines        297971   298128     +157     
  Branches      43363    43407      +44     
============================================
- Hits         213741   213647      -94     
- Misses        66369    66613     +244     
- Partials      17861    17868       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.