Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Optimize NodeIndicesStats output behind flag #15513

Merged
merged 5 commits into from
Sep 4, 2024
Merged

[Backport 2.x] Optimize NodeIndicesStats output behind flag #15513

merged 5 commits into from
Sep 4, 2024

Conversation

Pranshu-S
Copy link
Contributor

Backport e146f13 from #14454.

github-actions bot and others added 2 commits August 29, 2024 15:43
@github-actions
Optimize NodeIndicesStats output behind flag (opensearch-project#14454)
7d70148 
* Optimize NodeIndicesStats output behind flag

Signed-off-by: Pranshu Shukla <pranshushukla06@gmail.com>
(cherry picked from commit e146f13)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Pranshu-S
Updating versions for NodeIndicesStats Optimisation to 2.17
00d4d7e 
Signed-off-by: Pranshu Shukla <pranshushukla06@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 00d4d7e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 00d4d7e: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.63265% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (b408ef8) to head (3f65d58).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../java/org/opensearch/indices/NodeIndicesStats.java 85.71% 7 Missing and 5 partials ⚠️
...in/java/org/opensearch/indices/IndicesService.java 25.00% 2 Missing and 1 partial ⚠️
...h/action/admin/indices/stats/CommonStatsFlags.java 75.00% 0 Missing and 2 partials ⚠️
...rg/opensearch/rest/action/cat/RestNodesAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15513      +/-   ##
============================================
+ Coverage     71.63%   71.80%   +0.17%     
- Complexity    64164    64329     +165     
============================================
  Files          5251     5251              
  Lines        300418   300493      +75     
  Branches      43722    43741      +19     
============================================
+ Hits         215210   215778     +568     
+ Misses        67218    66691     -527     
- Partials      17990    18024      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pranshu-S
Merge branch '2.x' into backport/backport-14454-to-2.x
092397a 
Signed-off-by: Pranshu Shukla <55992439+Pranshu-S@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

✅ Gradle check result for 092397a: SUCCESS

@Pranshu-S
Merge branch '2.x' into backport/backport-14454-to-2.x
7694036 
Signed-off-by: Pranshu Shukla <55992439+Pranshu-S@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for 7694036: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Pranshu-S
Merge branch '2.x' into backport/backport-14454-to-2.x
3f65d58 
Signed-off-by: Pranshu Shukla <55992439+Pranshu-S@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 3f65d58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja shwetathareja mentioned this pull request Sep 4, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 3f65d58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

5 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 3f65d58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 3f65d58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 3f65d58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 3f65d58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 3f65d58: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for 3f65d58: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@shwetathareja shwetathareja merged commit d2ae53e into opensearch-project:2.x Sep 4, 2024
35 checks passed
This was referenced Sep 6, 2024
Open
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranshu-S @shwetathareja