Enhance OpenSearch APIs annotation processor with OpenSearch version validation #15502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
…validation Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
force-pushed
the
add.version.validation
branch
from
74a7296
to
ef91cf6
Compare
|
❌ Gradle check result for 74a7296: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15502 +/- ##
============================================
- Coverage 71.90% 71.77% -0.13%
+ Complexity 63481 63376 -105
============================================
Files 5244 5244
Lines 296798 296829 +31
Branches 42852 42860 +8
============================================
- Hits 213414 213055 -359
- Misses 65917 66301 +384
- Partials 17467 17473 +6 ☔ View full report in Codecov by Sentry. |
|
@peternied @dblock @andrross @msfroh if you have a time folks to look, much appreciated |
peternied
reviewed
Aug 29, 2024
.../common/src/main/java/org/opensearch/common/annotation/processor/ApiAnnotationProcessor.java
Show resolved
Hide resolved
peternied
approved these changes
Aug 29, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…validation (opensearch-project#15502) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance OpenSearch APIs annotation processor with OpenSearch version validation
Related Issues
Coming from #15497
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.