Adding translog durability validation in index templates #15494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shourya035
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❕ Gradle check result for 13939c8: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15494 +/- ##
============================================
+ Coverage 71.81% 71.94% +0.12%
- Complexity 63456 63539 +83
============================================
Files 5246 5246
Lines 296982 296991 +9
Branches 42894 42896 +2
============================================
+ Hits 213281 213665 +384
+ Misses 66230 65737 -493
- Partials 17471 17589 +118 ☔ View full report in Codecov by Sentry. |
mgodwan
reviewed
Aug 29, 2024
mgodwan
reviewed
Aug 29, 2024
server/src/test/java/org/opensearch/cluster/metadata/MetadataIndexTemplateServiceTests.java
Outdated
Show resolved
Hide resolved
mgodwan
approved these changes
Aug 29, 2024
|
❕ Gradle check result for 2330a12: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
linuxpi
reviewed
Aug 29, 2024
server/src/main/java/org/opensearch/cluster/metadata/MetadataIndexTemplateService.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/MetadataIndexTemplateService.java
Show resolved
Hide resolved
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
shourya035
force-pushed
the
async-tlog-template
branch
from
2330a12
to
d03dfb5
Compare
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
|
❌ Gradle check result for d03dfb5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
linuxpi
approved these changes
Aug 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
--------- Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com> (cherry picked from commit 57a597f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Aug 30, 2024
…5523) --------- (cherry picked from commit 57a597f) Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…project#15494) --------- Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restricting index template creation if
cluster.remote_store.index.restrict.async-durabilityis set totrueand the incoming index template setting hasindex.translog.durabilitysetting asasyncRelated Issues
Resolves #[Issue number to be closed when this PR is merged]
#15493
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.