Array, passed to Objects.hash(), should be wrapped into Arrays.hashCode() #15383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
dk2k
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15383 +/- ##
============================================
+ Coverage 71.93% 71.96% +0.03%
- Complexity 63223 63226 +3
============================================
Files 5214 5214
Lines 295938 295938
Branches 42754 42754
============================================
+ Hits 212876 212968 +92
+ Misses 65601 65480 -121
- Partials 17461 17490 +29 ☔ View full report in Codecov by Sentry. |
|
How does this change the behavior of this code? Needs a test? |
| @@ -103,7 +103,7 @@ public boolean equals(final Object o) { | |||
|
|
|||
| @Override | |||
| public int hashCode() { | |||
| return Objects.hash(trimAboveSeqNo, maxSeenAutoIdTimestampOnPrimary, operations); | |||
| return Objects.hash(trimAboveSeqNo, maxSeenAutoIdTimestampOnPrimary, Arrays.hashCode(operations)); | |||
There was a problem hiding this comment.
We are increasing time complexity by doing this change for sure. Is there a specific reason for doing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array, passed to Objects.hash(), should be wrapped into Arrays.hashCode()