Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DerivedFieldQuery to support concurrent search. #15326

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Fix DerivedFieldQuery to support concurrent search. #15326

merged 8 commits into from
Aug 27, 2024

Commits on Aug 22, 2024

  1. Fix DerivedFieldQuery to support concurrent search. 

    This change updates DerivedFieldQuery to create a separate ValueFetcher instance per thread.
The DerivedFieldValueFetcher is not thread safe in that it holds a ref to a compiled DerivedFieldScript that is
created per thread.  Each script also holds a SourceLookup object that is not thread safe.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f3d28a3 View commit details
    Browse the repository at this point in the history

  2. Fix broken cases relying on ObjectDerivedFieldValueFetcher. 

    DerivedFieldQuery will accept a supplier for a valueFetcher rather than constructing it.
This ensures that the DerivedFieldType creating the query (obj or regular) passes the correct supplier func.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1a49091 View commit details
    Browse the repository at this point in the history

  3. remove unused clone method 

    Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    79f273a View commit details
    Browse the repository at this point in the history

  4. Add changelog entry 

    Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    134066a View commit details
    Browse the repository at this point in the history

  5. add an extra test for DerivedFieldType multiPhraseQuery 

    Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7cc1a6b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. more coverage 

    Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    917ebd5 View commit details
    Browse the repository at this point in the history

  2. add tests for normalizedWildcard and phrase prefix 

    Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    1520b44 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 15007 

    Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
    @mch2
    mch2 authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2373d0f View commit details
    Browse the repository at this point in the history