Refactor remote writeable entity and store to make it more reusable #15210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bukhtawar
requested review from
anasalkouz,
andrross,
ashking94,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
3 tasks
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Bukhtawar
force-pushed
the
main-refactor-entity
branch
from
40f2d45
to
6379459
Compare
|
❌ Gradle check result for 40f2d45: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b71af8c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15210 +/- ##
============================================
+ Coverage 71.89% 71.92% +0.03%
+ Complexity 63052 63033 -19
============================================
Files 5189 5190 +1
Lines 295202 295204 +2
Branches 42668 42668
============================================
+ Hits 212229 212327 +98
+ Misses 65586 65427 -159
- Partials 17387 17450 +63 ☔ View full report in Codecov by Sentry. |
soosinha
reviewed
Aug 13, 2024
...r/src/main/java/org/opensearch/common/remote/AbstractClusterMetadataWriteableBlobEntity.java
Show resolved
Hide resolved
sachinpkale
reviewed
Aug 13, 2024
...r/src/main/java/org/opensearch/common/remote/AbstractClusterMetadataWriteableBlobEntity.java
Show resolved
Hide resolved
sachinpkale
approved these changes
Aug 13, 2024
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…pensearch-project#15210) * Refactor remote writeable entity and store to make it more reusable Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…pensearch-project#15210) * Refactor remote writeable entity and store to make it more reusable Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aims to make the remote entity classes more reusable by moving them to commons and removing dependencies around remote cluster state
Related Issues
Resolves #15180
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.