Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Template creation using context (#14811) #14956

Merged

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Jul 24, 2024

Backport of #14811

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mgodwan mgodwan force-pushed the index-template-create-pr-2x branch from 55f2c54 to cf0ec67 Compare July 24, 2024 13:36
* Template creation using context

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@mgodwan mgodwan force-pushed the index-template-create-pr-2x branch from cf0ec67 to 689e382 Compare July 24, 2024 13:37
Copy link
Contributor

❌ Gradle check result for 55f2c54: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for cf0ec67: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 689e382: SUCCESS

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 42 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (82c4c1e) to head (689e382).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
.../java/org/opensearch/cluster/metadata/Context.java 67.34% 14 Missing and 2 partials ⚠️
...r/applicationtemplates/SystemTemplateMetadata.java 20.00% 6 Missing and 2 partials ⚠️
...plicationtemplates/TemplateRepositoryMetadata.java 0.00% 6 Missing ⚠️
...arch/cluster/metadata/ComposableIndexTemplate.java 75.00% 1 Missing and 3 partials ⚠️
...cluster/metadata/MetadataIndexTemplateService.java 94.11% 2 Missing and 1 partial ⚠️
...ate/post/TransportSimulateIndexTemplateAction.java 0.00% 2 Missing ⚠️
...template/post/TransportSimulateTemplateAction.java 0.00% 2 Missing ⚠️
...ch/cluster/coordination/OpenSearchNodeCommand.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14956      +/-   ##
============================================
- Coverage     71.56%   71.54%   -0.02%     
- Complexity    62672    62745      +73     
============================================
  Files          5121     5122       +1     
  Lines        294267   294412     +145     
  Branches      42880    42903      +23     
============================================
+ Hits         210579   210647      +68     
- Misses        65978    66111     +133     
+ Partials      17710    17654      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 8b55e04 into opensearch-project:2.x Jul 24, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants