Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use Lucene provided Persian stem #14894

Merged

Conversation

ebraminio
Copy link
Contributor

@ebraminio ebraminio commented Jul 23, 2024

Lucene provided Persian stem apparently isn't hooked yet and this change is doing that based on what is done for Arabic stem support.

Following #14847 (comment)

…4847)

Lucene provided Persian stem apparently isn't hooked yet and this change is
doing that based on what is done for Arabic stem support.

Signed-off-by: Ebrahim Byagowi <ebrahim@gnu.org>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit 4e45c9e)
@ebraminio ebraminio changed the title [Backport 2.x] Use Lucene provided Persian stem (#14847) [Backport 2.x] Use Lucene provided Persian stem Jul 23, 2024
Copy link
Contributor

❌ Gradle check result for c2cac16: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Copy link
Contributor

✅ Gradle check result for 7bcd90b: SUCCESS

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (788a7fe) to head (f93f41b).
Report is 11 commits behind head on 2.x.

Files Patch % Lines
...analysis/common/PersianStemTokenFilterFactory.java 0.00% 3 Missing ⚠️
...rch/analysis/common/StemmerTokenFilterFactory.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14894      +/-   ##
============================================
+ Coverage     71.52%   71.54%   +0.02%     
- Complexity    62546    62606      +60     
============================================
  Files          5110     5119       +9     
  Lines        293684   293965     +281     
  Branches      42800    42835      +35     
============================================
+ Hits         210063   210326     +263     
- Misses        65978    66028      +50     
+ Partials      17643    17611      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Copy link
Contributor

✅ Gradle check result for f93f41b: SUCCESS

@dblock dblock added the v2.16.0 Issues and PRs related to version 2.16.0 label Jul 23, 2024
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Copy link
Contributor

❕ Gradle check result for 5ddc8c3: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@dblock dblock merged commit 96454f8 into opensearch-project:2.x Jul 23, 2024
29 of 30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/backport-2.16
# Create a new branch
git switch --create backport/backport-14894-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 96454f853955dcc089f2e8284420f4ac345a8c8b
# Push it to GitHub
git push --set-upstream origin backport/backport-14894-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-14894-to-2.16.

@dblock
Copy link
Member

dblock commented Jul 23, 2024

@ebraminio If you really, really want this in 2.16, backport manually please to that branch that was cut yesterday.

kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…4847) (opensearch-project#14894)

Lucene provided Persian stem apparently isn't hooked yet and this change is
doing that based on what is done for Arabic stem support.

Signed-off-by: Ebrahim Byagowi <ebrahim@gnu.org>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit 4e45c9e)

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.16 v2.16.0 Issues and PRs related to version 2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants