[Remote State] Fix component name for ClusterState custom #14477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14477 +/- ##
============================================
+ Coverage 71.42% 71.62% +0.20%
- Complexity 59978 62060 +2082
============================================
Files 4985 5118 +133
Lines 282275 291978 +9703
Branches 40946 42211 +1265
============================================
+ Hits 201603 209138 +7535
- Misses 63999 65600 +1601
- Partials 16673 17240 +567 ☔ View full report in Codecov by Sentry. |
shwetathareja
approved these changes
Jun 21, 2024
shwetathareja
merged commit 3a516cf
into
opensearch-project:main
51 of 53 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3a516cf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja
pushed a commit
that referenced
this pull request
Jun 21, 2024
(cherry picked from commit 3a516cf) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3a516cf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja
pushed a commit
that referenced
this pull request
Jun 21, 2024
(cherry picked from commit 3a516cf) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
@shiv0408 I understand you wanted this in 2.15 ideally so it had to go fast. Are you writing a test for this? |
|
@dblock Yes, I am working on adding tests for this class as a whole. I have linked the WIP PR for that, I could not finish the tests today. I will be adding more tests over the week and make the PR ready to review by Monday. |
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…opensearch-project#14485) (cherry picked from commit 3a516cf) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are expecting component name for ClusterState.Custom to be of
cluster-state-custom--<custom_name>. This was missed during refactoring while PR review and there were no test to catch this change. For tests, I am already working on more tests in #14476.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.