Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Integration Test for Index_Node_Left_Delayed_Timeout setting #13813

Closed

Conversation

gargharsh3134
Copy link
Contributor

@gargharsh3134 gargharsh3134 commented May 24, 2024

Description

This change adds an integ test to simulate the behaviour called out in #13962.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Copy link
Contributor

❌ Gradle check result for 3e19a5d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Copy link
Contributor

❕ Gradle check result for 54c7e06: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (b15cb0c) to head (54c7e06).
Report is 482 commits behind head on main.

Current head 54c7e06 differs from pull request most recent head 12cd753

Please upload reports for the commit 12cd753 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13813      +/-   ##
============================================
+ Coverage     71.42%   71.63%   +0.21%     
- Complexity    59978    61268    +1290     
============================================
  Files          4985     5062      +77     
  Lines        282275   287907    +5632     
  Branches      40946    41692     +746     
============================================
+ Hits         201603   206235    +4632     
- Misses        63999    64655     +656     
- Partials      16673    17017     +344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rajiv-kv rajiv-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… mode

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Copy link
Contributor

❌ Gradle check result for 52421bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
Copy link
Contributor

❌ Gradle check result for 12cd753: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gargharsh3134
Copy link
Contributor Author

Closing this PR. It has been addressed as part of this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants