Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider the breaking changes check policy to detect breaking changes against released versions #13292

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Apr 18, 2024

Description

Reconsider the breaking changes check policy to detect breaking changes against released versions. The check still remains disabled for main for now.

Related Issues

Resolves #13275

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request RFC Issues requesting major changes labels Apr 18, 2024
…es against released versions

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta added the backport 2.x Backport to 2.x branch label Apr 18, 2024
server/build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

❌ Gradle check result for 0d84dc4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 54ac60d: SUCCESS

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (b15cb0c) to head (fb7eafd).
Report is 196 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13292      +/-   ##
============================================
+ Coverage     71.42%   71.50%   +0.08%     
- Complexity    59978    60668     +690     
============================================
  Files          4985     5039      +54     
  Lines        282275   285434    +3159     
  Branches      40946    41338     +392     
============================================
+ Hits         201603   204108    +2505     
- Misses        63999    64426     +427     
- Partials      16673    16900     +227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…cmp tasks

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

❌ Gradle check result for 7cbb3a0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 0592dd1: SUCCESS

Copy link
Contributor

✅ Gradle check result for fb7eafd: SUCCESS

@reta reta merged commit b4692c8 into opensearch-project:main Apr 19, 2024
28 of 29 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13292-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4692c897ec4b19161417147d29b116671616fe1
# Push it to GitHub
git push --set-upstream origin backport/backport-13292-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13292-to-2.x.

reta added a commit to reta/OpenSearch that referenced this pull request Apr 19, 2024
…es against released versions (opensearch-project#13292)

* Reconsider the breaking changes check policy to detect breaking changes against released versions

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Add an ability to provide the target version to compare with for japicmp tasks

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Add documentation for japicmp tasks

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit b4692c8)
reta added a commit to reta/OpenSearch that referenced this pull request Apr 19, 2024
…es against released versions (opensearch-project#13292)

* Reconsider the breaking changes check policy to detect breaking changes against released versions

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Add an ability to provide the target version to compare with for japicmp tasks

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Add documentation for japicmp tasks

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit b4692c8)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
peternied pushed a commit that referenced this pull request Apr 19, 2024
…es against released versions (#13292) (#13310)

(cherry picked from commit b4692c8)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. enhancement Enhancement or improvement to existing feature or request RFC Issues requesting major changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Reconsider the breaking changes check policy
2 participants