Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakiness in testDontAllowSwitchingCompatibilityModeForClusterWit… #13281

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Apr 18, 2024

…hMultipleVersions

Description

  • Fixes the flakiness in org.opensearch.action.support.clustermanager.TransportClusterManagerNodeActionTests.testDontAllowSwitchingCompatibilityModeForClusterWithMultipleVersions.
  • Was using randomCompatibleVersion(random(), version1) to pick version2 which does not guarantee version2 being different from version1 leading to an assertion failure at assert version1.equals(version2) == false
  • Now specifically using two compatible and different OpenSearch versions for the purpose of the test

Related Issues

Resolves #13240

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…hMultipleVersions

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
@github-actions github-actions bot added bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run labels Apr 18, 2024
@ltaragi ltaragi added skip-changelog and removed bug Something isn't working flaky-test Random test failure that succeeds on second run Cluster Manager labels Apr 18, 2024
@github-actions github-actions bot added bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run labels Apr 18, 2024
Copy link
Contributor

❌ Gradle check result for 8701a41: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi
Copy link
Contributor Author

ltaragi commented Apr 18, 2024

❌ Gradle check result for 8701a41: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky Tests: #11979, #12197

Copy link
Contributor

✅ Gradle check result for 8701a41: SUCCESS

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (84679de) to head (8701a41).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13281      +/-   ##
============================================
- Coverage     71.48%   71.43%   -0.05%     
+ Complexity    60670    60655      -15     
============================================
  Files          5040     5040              
  Lines        285456   285456              
  Branches      41338    41338              
============================================
- Hits         204044   203905     -139     
- Misses        64589    64705     +116     
- Partials      16823    16846      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 61ff5f8 into opensearch-project:main Apr 18, 2024
81 of 82 checks passed
@dblock dblock added the backport 2.x Backport to 2.x branch label Apr 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2024
…hMultipleVersions (#13281)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit 61ff5f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Apr 19, 2024
…hMultipleVersions (#13281) (#13287)

(cherry picked from commit 61ff5f8)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run skip-changelog
Projects
Status: ✅ Done
3 participants