Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute flaky test testMultiGetWithNetworkDisruption_FailOpenEnabled #12562

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Mar 8, 2024

Description

This PR mutes flaky test testMultiGetWithNetworkDisruption_FailOpenEnabled until fixed.

Related Issues

#10755

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Compatibility status:

Checks if related components are compatible with change 7bda0a0

Incompatible components

Incompatible components: [https://github.com/opensearch-project/ml-commons.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Mar 8, 2024

❕ Gradle check result for 4fb3736: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (b15cb0c) to head (7bda0a0).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12562      +/-   ##
============================================
+ Coverage     71.42%   71.46%   +0.04%     
- Complexity    59978    60009      +31     
============================================
  Files          4985     4985              
  Lines        282275   282320      +45     
  Branches      40946    40949       +3     
============================================
+ Hits         201603   201756     +153     
+ Misses        63999    63873     -126     
- Partials      16673    16691      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

❌ Gradle check result for 5f625b3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 8, 2024

❌ Gradle check result for 7dcc20b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 8, 2024

❌ Gradle check result for f2c998b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ec5f86d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Anshu Agarwal added 3 commits March 12, 2024 09:42
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Copy link
Contributor

❕ Gradle check result for 7bda0a0: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@anshu1106
Copy link
Contributor Author

      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Flaky test - #12197

@kotwanikunal kotwanikunal added skip-changelog backport 2.x Backport to 2.x branch labels Mar 12, 2024
@kotwanikunal kotwanikunal merged commit 1e9c05c into opensearch-project:main Mar 12, 2024
35 of 36 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2024
…2562)

* Mute flaky test testMultiGetWithNetworkDisruption_FailOpenEnabled

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

* mute flaky test testShardRoutingWithNetworkDisruption_FailOpenEnabled

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

* spotless fix

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
(cherry picked from commit 1e9c05c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Mar 15, 2024
…2562) (#12623)

* Mute flaky test testMultiGetWithNetworkDisruption_FailOpenEnabled



* mute flaky test testShardRoutingWithNetworkDisruption_FailOpenEnabled



* spotless fix



---------



(cherry picked from commit 1e9c05c)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…ensearch-project#12562)

* Mute flaky test testMultiGetWithNetworkDisruption_FailOpenEnabled

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

* mute flaky test testShardRoutingWithNetworkDisruption_FailOpenEnabled

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

* spotless fix

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ensearch-project#12562)

* Mute flaky test testMultiGetWithNetworkDisruption_FailOpenEnabled

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

* mute flaky test testShardRoutingWithNetworkDisruption_FailOpenEnabled

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

* spotless fix

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>

---------

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants