Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Snapshot Interop] Fix Flakiness in Snapshot Interop C… #12193

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

harishbhakuni
Copy link
Contributor

@harishbhakuni harishbhakuni commented Feb 6, 2024

…ode (#9795)

Description

Backporting 951f051 to 2.x which failed as part of #9867

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ode (opensearch-project#9795)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Compatibility status:

Checks if related components are compatible with change f502ce5

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git]

@harishbhakuni harishbhakuni added the v2.12.0 Issues and PRs related to version 2.12.0 label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for f502ce5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harishbhakuni
Copy link
Contributor Author

harishbhakuni commented Feb 6, 2024

org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads: #10945
org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction: #12197

@harishbhakuni harishbhakuni added v2.12.0 Issues and PRs related to version 2.12.0 and removed v2.12.0 Issues and PRs related to version 2.12.0 labels Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for f502ce5:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harishbhakuni
Copy link
Contributor Author

seeing this in the gradle check log:

time pass: 1380
Still running, wait for another 30 seconds before checking again, max timeout 7200
Jenkins Workflow Url: https://build.ci.opensearch.org/job/gradle-check/33400/
time pass: 1410
parse error: Invalid numeric literal at line 1, column 7
Complete the run, checking results now......
parse error: Invalid numeric literal at line 1, column 7
Please check jenkins url for logs: https://build.ci.opensearch.org/job/gradle-check/33400/
Result: 
Error: Process completed with exit code 1.

and opening workflow link failing with 5xx.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

❕ Gradle check result for f502ce5: UNSTABLE

  • TEST FAILURES:
      3 org.opensearch.cluster.MinimumClusterManagerNodesIT.classMethod
      2 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49c0c50) 71.15% compared to head (f502ce5) 71.18%.
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12193      +/-   ##
============================================
+ Coverage     71.15%   71.18%   +0.02%     
- Complexity    59675    59704      +29     
============================================
  Files          4921     4921              
  Lines        281132   281132              
  Branches      41184    41184              
============================================
+ Hits         200050   200119      +69     
+ Misses        64143    64115      -28     
+ Partials      16939    16898      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants