[Backport 2.x] Adding support for dynamically updating Leader/follower checker timeouts #11166
Conversation
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…uts (#10528) * making leader check timeout dynamic Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * making follower check timeout dynamic Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding tests for leader/follower check timeout Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * setting maximum and minimum timeout value for leader/follower checker Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding tests for checking boundary cases Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * changed the log file and added other suggested changes Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Addressing review comments Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * addressing proposed changes Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Applying checkstyle fixes Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing flakiness for existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Applying checkstyle fixes Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing the timeout value limits for randomSettings Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> (cherry picked from commit 0452d14) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
peternied,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale,
sohami and
msfroh
as code owners
Compatibility status:Checks if related components are compatible with change 17cab0e Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git] |
|
❌ Gradle check result for 17cab0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 17cab0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
|
❌ Gradle check result for 17cab0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 17cab0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 17cab0e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11166 +/- ##
==========================================
Coverage 70.88% 70.89%
+ Complexity 58926 58909 -17
==========================================
Files 4862 4862
Lines 278389 278397 +8
Branches 40806 40806
==========================================
+ Hits 197336 197360 +24
+ Misses 64289 64143 -146
- Partials 16764 16894 +130 ☔ View full report in Codecov by Sentry. |
Backport 0452d14 from #10528.