Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sort optimization for HALF_FLOAT #10999

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

gashutos
Copy link
Contributor

@gashutos gashutos commented Oct 30, 2023

Fixing - > #10997.
Disable point based sort optimization for half_flaot.
There is a way we can enable it back but it needs bigger code change and I will send out shortly. We will have to create HalfFloatNumericSourceComparator as well HafFloatComparator same as we did for unsigned_long for that.
Created follow up issue here to make it back.
#10998

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

@gashutos
Copy link
Contributor Author

@reta need your quick review here :) , just got one nasty bug with half_float sort queries.

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Compatibility status:

Checks if related components are compatible with change 950d89b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #10999 (950d89b) into main (4efa6d7) will increase coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main   #10999      +/-   ##
============================================
+ Coverage     71.21%   71.32%   +0.10%     
- Complexity    58650    58802     +152     
============================================
  Files          4870     4870              
  Lines        276610   276610              
  Branches      40206    40206              
============================================
+ Hits         196984   197281     +297     
+ Misses        63194    62897     -297     
  Partials      16432    16432              
Files Coverage Δ
...nsearch/index/fielddata/IndexNumericFieldData.java 85.07% <100.00%> (ø)

... and 452 files with indirect coverage changes

@reta reta merged commit 448635f into opensearch-project:main Oct 30, 2023
19 of 20 checks passed
@reta reta added bug Something isn't working backport 2.x Backport to 2.x branch backport 2.11 v3.0.0 Issues and PRs related to version 3.0.0 v2.12.0 Issues and PRs related to version 2.12.0 v2.11.1 Issues targeting release v2.11.1 labels Oct 30, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2023
Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
(cherry picked from commit 448635f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.11
# Create a new branch
git switch --create backport/backport-10999-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 448635f77855108afedfe6f2e5c07a2f6c37746c
# Push it to GitHub
git push --set-upstream origin backport/backport-10999-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-10999-to-2.11.

gashutos added a commit to gashutos/OpenSearch that referenced this pull request Oct 30, 2023
Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
@gashutos
Copy link
Contributor Author

reta pushed a commit that referenced this pull request Oct 30, 2023
Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
reta pushed a commit that referenced this pull request Oct 31, 2023
(cherry picked from commit 448635f)

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.11 backport-failed bug Something isn't working v2.11.1 Issues targeting release v2.11.1 v2.12.0 Issues and PRs related to version 2.12.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants